Skip to content

feat(refactor): Move common exceptions out of the discover db#111713

Merged
manessaraj merged 2 commits intomasterfrom
sarajmanes/refactor/issue_exceptions_to_common_search
Mar 27, 2026
Merged

feat(refactor): Move common exceptions out of the discover db#111713
manessaraj merged 2 commits intomasterfrom
sarajmanes/refactor/issue_exceptions_to_common_search

Conversation

@manessaraj
Copy link
Copy Markdown
Contributor

@manessaraj manessaraj commented Mar 27, 2026

Move IssueSearchQueryException to common exceptions module.

@manessaraj manessaraj requested review from a team as code owners March 27, 2026 15:20
@manessaraj manessaraj removed request for a team March 27, 2026 15:20
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 27, 2026
@manessaraj manessaraj requested a review from wmak March 27, 2026 15:20
Comment thread src/sentry/models/group.py Outdated
).filter(project__organization=organization_id)

groups = list(base_group_queryset.filter(short_id_lookup).select_related("project"))
groups = list(base_group_queryset.filter(short_id_lookup))
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we changing this query?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be changed. Undoing this; We need to fetch projects as part of groups, this does an inner join on projects.

Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Move IssueSearchQueryException to common exceptions module

Remove future annotation

Remove future annotation
@manessaraj manessaraj force-pushed the sarajmanes/refactor/issue_exceptions_to_common_search branch from d15157c to 2308e3c Compare March 27, 2026 15:32
@getsentry getsentry deleted a comment from sentry bot Mar 27, 2026
@getsentry getsentry deleted a comment from cursor bot Mar 27, 2026
@manessaraj manessaraj requested a review from a team as a code owner March 27, 2026 15:44
@manessaraj manessaraj merged commit 93dc014 into master Mar 27, 2026
101 of 104 checks passed
@manessaraj manessaraj deleted the sarajmanes/refactor/issue_exceptions_to_common_search branch March 27, 2026 16:15
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants